Simplify after date transition boundaries.

flatheadmill · flatheadmill · commit 54ebf530a6a6 · 2020-01-28T01:58:25.000-06:00
When we are looking for the first day of the week greater than a certain
date, we already have the start date. For some reason I was starting at
the first of the month instead of just starting at the given date. I was
performing the greater than or equal too in the loop, instead of just
looking for the day of the week. This will throw off the seek if the
first day of the week (i.e. first Friday on or after the 29th) occurs in
the next month.
diff --git a/util/transitions.js b/util/transitions.js
@@ -17,13 +17,12 @@
       // to create the full date in the loop, Amman says no.
       while ((fields = new Date(Date.UTC(year, rule.month, day))).getUTCDay() != i) day--;
     } else {
-      var min = parseInt(date[4], 10);
+      var day = parseInt(date[4], 10);
       for (var i = 0, stop = ABBREV.length; i < stop; i++)
         if (ABBREV[i] === date[3]) break;
-      day = 1;
       for (;;) {
         fields = new Date(Date.UTC(year, rule.month, day));
-        if (fields.getUTCDay() === i && fields.getUTCDate() >= min) break;
+        if (fields.getUTCDay() === i) break;
         day++;
       }
     }
