ref(navigation): remove hasPageFrame feature flag checks#116018
Draft
natemoo-re wants to merge 7 commits into
Draft
ref(navigation): remove hasPageFrame feature flag checks#116018natemoo-re wants to merge 7 commits into
natemoo-re wants to merge 7 commits into
Conversation
The page-frame feature flag is 100% rolled out. Inline true for all useHasPageFrameFeature() callsites and eliminate dead code branches.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.62% |
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
The outlets need to exist for slot content to render, but they must not be inside the test container or they break toBeEmptyDOMElement() assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
page-framefeature flag has been 100% rolled out. This refactorsuseHasPageFrameFeature()callsites inviews/navigation/and eliminates dead code branches.Removes
MobileNavigation(replaced byMobilePageFrameNavigation), dead styled components (MobileNavigationLink,DesktopNavigationLink,SidebarNavigationLink,StyledReorderableFakeLink), and the legacy superuser warning block fromPrimaryNavigationSidebarHeader.