CLDR-19466 Implement Kotlin-based decimal format test data generator and test classes#5715
CLDR-19466 Implement Kotlin-based decimal format test data generator and test classes#5715younies wants to merge 2 commits into
Conversation
macchiati
left a comment
There was a problem hiding this comment.
Adding kotlin is a significant step, and needs justification. Also, what is the difference between the .kt.TSV and the .TSV files? Why would an application using those care about the programming language used to generate them
There was a problem hiding this comment.
Please don't add more TestFmwk tests.
Add a new JUnit test (not under the unittest package but under the package of the file under test.)
There was a problem hiding this comment.
Please don't add more TestFmwk tests.
That has not been decided; please add this to the CLDR Ops Agenda
There was a problem hiding this comment.
can you make a JUnit test in Kotlin?
There was a problem hiding this comment.
That's moot for now, since there has been no proposal to add Kotlin at all.
srl295
left a comment
There was a problem hiding this comment.
structure generally OK but please use JUnit
| } | ||
|
|
||
| @JvmStatic | ||
| fun main(args: Array<String>) { |
There was a problem hiding this comment.
This is very unfriendly for testing.
Hard to trigger, easy to forget about it, completely undocumented.
Can we make this a regular test class that runs tests?
|
CLDR-19466
Implement Kotlin-based decimal format test data generator and test classes
Add the Kotlin-based implementation of the decimal and compact decimal format conformance test generator and the corresponding verification tests, along with their generated TSV outputs.
Key Changes:
GenerateDecimalFormatTestDataKt.ktto generate expected decimal formatted outputs.TestDecimalFormatKt.ktto verify the Kotlin-generated test data.decimal_kt.tsv,decimal_all_locales_kt.tsv,decimal_all_numbers_kt.tsv, anddecimal_random_5percent_kt.tsvunder common/testData/decimal/.###Note:
Build system configurations (pom.xml changes to enable Kotlin) and Java test suite registrations must be committed in a separate step to fully enable these tests.
ALLOW_MANY_COMMITS=true