Skip to content

KMSCryptoClient backed by OS-native keyring#1370

Open
edwinyyyu wants to merge 2 commits into
MemMachine:mainfrom
edwinyyyu:keyring_kms_crypto_client
Open

KMSCryptoClient backed by OS-native keyring#1370
edwinyyyu wants to merge 2 commits into
MemMachine:mainfrom
edwinyyyu:keyring_kms_crypto_client

Conversation

@edwinyyyu
Copy link
Copy Markdown
Contributor

@edwinyyyu edwinyyyu commented Apr 24, 2026

Purpose of the change

First implementation of a KMSCryptoClient.

Description

Based on #1365
Can be used to use KEK stored in OS-native keychain.

Type of change

[Please delete options that are not relevant.]

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

Manually verified with committed script.

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

@edwinyyyu edwinyyyu force-pushed the keyring_kms_crypto_client branch 2 times, most recently from dc8a022 to f6807cf Compare May 4, 2026 16:51
edwinyyyu added 2 commits May 8, 2026 10:58
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu edwinyyyu force-pushed the keyring_kms_crypto_client branch from f6807cf to cdef919 Compare May 8, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant