fix(core): skip DOM trigger registration in DeferBlockBehavior.Manual…#68866
Open
Rafaelkocharli wants to merge 1 commit into
Open
fix(core): skip DOM trigger registration in DeferBlockBehavior.Manual…#68866Rafaelkocharli wants to merge 1 commit into
Rafaelkocharli wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
When using
DeferBlockBehavior.Manualin tests (e.g. Jest + JSDOM), Angular stillregisters DOM observers for
@defertrigger functions (on viewport,on hover,on interaction). This causesReferenceError: IntersectionObserver is not definedand similar errors, because JSDOM does not implement these browser APIs.
Issue Number: #68800
What is the new behavior?
ɵɵdeferOnViewport,ɵɵdeferOnHover, andɵɵdeferOnInteractionnow callshouldTriggerDeferBlock()before registering DOM triggers. In Manual modethe check returns
false, so no observers or event listeners are attached.The existing SSR guard is replaced by this check, which already covers the
server-side case as well.
Does this PR introduce a breaking change?
Other information
shouldTriggerDeferBlockwas madeexportso it can be reused ininstructions.tsalongside the existingshouldAttachTrigger.ɵɵdeferOnIdleis unaffected — it delegates toscheduleDelayedTriggerwhich already gates on
shouldTriggerDeferBlockinternally.