Fix Safe Areas not working on iOS#2075
Open
Alphalaneous wants to merge 1 commit into
Open
Conversation
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a somewhat cheaty fix, but is needed due to how the Geode launcher on iOS handles resolution.
By default GD's resolution is hard set at that of an iPhone 11 Pro for some reason. The width of that is 2436 on taller iPhones, and GD does this check.
This check fails in the launcher, due to the resolution being different and actually following the device (Funnily enough, this means this bug does not exist on iPhone 11 Pros using the Geode launcher). My solution is to merely set the bool needed to if the safe zone size geode provides is different than the window size.
Note that the node IDs mod does break some of these safe areas. Most actually work fine since detaching preserves position. But on ones that position is changed, it will likely still have an overlap. I will also be making a node IDs PR to accompany this one.