Axios update#7692
Open
nicof38 wants to merge 5 commits into
Open
Conversation
Member
|
Did you happen to check if there are any breaking changes in the new version compared to the one we use? |
Contributor
Author
|
yes, there are breaking changes listed in the migration guide, and all mainly related to error handling there that is probably why I do not have any issue with tests. With Axios 0.x - Some HTTP error codes didn't throw, where with Axios 1.x - All HTTP errors throw consistently May need to discuss about what strategy may be applied, vs the 3 that are proposed by axios project ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Dependency update
Description
Bumps axios from 0.28.0 to 1.15.0.
How is this tested?
Related Tickets & Documents
take over PR-7621
Mobile & Desktop Screenshots/Recordings (if there are UI changes)