feat(datastore): drop Python 3.7-3.9 support and regenerate#17199
feat(datastore): drop Python 3.7-3.9 support and regenerate#17199chalmerlowe wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the supported Python versions for the google-cloud-datastore package, dropping support for Python 3.7, 3.8, and 3.9 and setting the new minimum version to 3.10. The documentation and example commands in CONTRIBUTING.rst and README.rst have been updated to reflect these changes. Feedback suggests using a stable Python version (like 3.10) instead of the alpha version 3.14 in documentation examples for system and sample tests to ensure they work reliably for contributors.
| ) | ||
| count: 1 | ||
|
|
||
| - paths: [ |
There was a problem hiding this comment.
Updated synthtool README template to reference 3.10: googleapis/synthtool#2178
Updated librarian to point at new synthtool commit: googleapis/librarian#6111
There was a problem hiding this comment.
In this case, I would like to push back on deleting datastore-integration.yaml.
The datastore-integration.yaml file is not my addition. It has been in this repo for 3 months and was added by ohmayr. I am simply updating the ruleset in the existing file.
If we want to remove it and/or merge the content with another file, I recommend that be done in a separate PR.
There are at least 13 files in the post-processing directory that are focused on a single package per file and if we want to start merging content or moving things around, I recommend we do so in a controlled and organized manner.
|
|
||
| - The feature must work fully on the following CPython versions: | ||
| 3.7, 3.8, 3.9, 3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows. | ||
| 3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows. |
There was a problem hiding this comment.
Should we move packages/google-cloud-datastore/CONTRIBUTING.rst to a top level /CONTRIBUTING.rst file so we don't need to maintain the same content in all handwritten packages? We may decide to still have packages/google-cloud-datastore/CONTRIBUTING.rst but only include package specific details that aren't part of the root /CONTRIBUTING.rst file.
There was a problem hiding this comment.
I agree that this is a good, long term step. I would prefer that we keep this PR focused on one task: generation using 1.32.0 and we relegate work on consolidating CONTRIBUTING.rst in a separate PR in a future sprint.
164e166 to
ebb370d
Compare
Regenerates google-cloud-datastore using the custom v0.14.0 pseudo-version librarian build on top of pristine, up-to-date main. - Segregates all post-processing EOL warning rules into package-specific datastore-integration.yaml, keeping global configs clean - Natively drop Python 3.9 support in constraints and python_requires pins using generator 1.32.0 - Correctly generates setup.py with grpcio>=1.44.0 natively, avoiding any version regressions - Manually updates contributing.rst warning filters and commands to drop Python 3.7-3.9 and bump system/sample tests base to 3.10 - Passes all Nox docker validations (unit, lint, prerelease_deps, core_deps_from_source) cleanly in parallel
ebb370d to
6331554
Compare
Drops support for Python 3.7, 3.8, and 3.9 and aligns EOL documentation versions accordingly.
Changes
README.rstupdated based on synthtool revisions to declare Supported Python Versions as>= 3.10, including 3.14and Unsupported Python Versions as<= 3.9.CONTRIBUTING.rstto remove EOL references, update standard CPython support ranges, align system/sample test run commands to3.14(e.g.,system-3.14), and update the global Python 3 baseline statement to3.10.