Skip to content

chore(bigframes): move the load test script under .kokoro/continuous/#17225

Open
sycai wants to merge 1 commit into
mainfrom
sycai_load_test
Open

chore(bigframes): move the load test script under .kokoro/continuous/#17225
sycai wants to merge 1 commit into
mainfrom
sycai_load_test

Conversation

@sycai
Copy link
Copy Markdown
Contributor

@sycai sycai commented May 21, 2026

This is to make sure the test still runs even when there has been no changes:

google-cloud-python/.kokoro/system.sh

Lines 156 to 161 in 3ef95d6

if [[ "${package_modified}" -gt 0 || "$KOKORO_BUILD_ARTIFACTS_SUBDIR" == *"continuous"* ]]; then
# Call the function - its internal exports won't affect the next loop
run_package_test "$package_name" || RETVAL=$?
else
echo "No changes in ${package_name} and not a continuous build, skipping."
fi

Tracking issue: b/509623551

@sycai sycai requested review from TrevorBergeron and tswast May 21, 2026 19:35
@sycai sycai marked this pull request as ready for review May 21, 2026 19:35
@sycai sycai requested a review from a team as a code owner May 21, 2026 19:35
@sycai sycai requested a review from parthea May 21, 2026 19:35
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes the Kokoro configuration file .kokoro/continuous/load-bigframes.cfg. A critical issue was identified regarding the deletion of common configuration files; specifically, removing these files without updating import references in other configuration files will cause Kokoro build failures.

I am having trouble creating individual review comments. Click here to see my feedback.

.kokoro/load/common.cfg (1-27)

high

Deleting this common configuration file while moving load-bigframes.cfg without updating its content will break the Kokoro job. Kokoro job configurations in this repository typically import a common.cfg from their directory. Since load-bigframes.cfg was renamed without any content changes, it still contains an import statement pointing to this deleted path (google-cloud-python/.kokoro/load/common.cfg), which will cause the build to fail. The moved configuration should be updated to reference a valid common configuration (e.g., in the continuous directory) or have the necessary settings inlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast Awaiting requested review from tswast

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

@parthea parthea Awaiting requested review from parthea

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sycai