Implement file explorer focus and add keybinds for renaming and deleting the currently selected file.#3834
Open
ryanabx wants to merge 2 commits into
Open
Implement file explorer focus and add keybinds for renaming and deleting the currently selected file.#3834ryanabx wants to merge 2 commits into
ryanabx wants to merge 2 commits into
Conversation
Implementing focus for the file explorer allows us to implement commands that respond to keymaps, such as `F2` to rename, and `Delete` to trash a file. Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
…file explorer. This commit binds `F2` to `file_explorer.rename` which renames the currently selected node, and `Delete` to `file_explorer.trash`, which trashes the selected node.
ryanabx
commented
Nov 16, 2025
| } | ||
|
|
||
| fn check_condition(&self, condition: Condition) -> bool { | ||
| self.naming.with_untracked(Naming::is_accepting_input) |
Contributor
Author
There was a problem hiding this comment.
I think the only thing I'm not 100% confident about is check_condition. In file_explorer, it seemed to be a bit different from the other panels, so that's something to look at.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif this change could be valuable to users