fix(updater): backport #9406 — respect autoUpdateCheck in Sparkle background checks#9705
Conversation
|
@pedromdbl You need to rebase and correct your sign-off line which contains the wrong mail address. Otherwise this is fine. 🙂 |
…ecks Backport of nextcloud#9406 to stable-4.0. The backgroundUpdateChecksAllowed delegate method only checked skipUpdateCheck() but ignored autoUpdateCheck(), causing Sparkle background update checks to always run regardless of the user's auto-update preference. This led to the update dialog appearing daily even after clicking "Install Update", as Sparkle's internal state machine became inconsistent. Similarly, backgroundCheckForUpdate() used !skipUpdateCheck() instead of autoUpdateCheck(). Fixes nextcloud#9704 Signed-off-by: Pedro Lino <pmdbl@sapo.pt>
3957536 to
476f1b0
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9705.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Backport of #9406 to
stable-4.0.backgroundUpdateChecksAllowednow checks both!config.skipUpdateCheck()andconfig.autoUpdateCheck()before allowing Sparkle background update checksbackgroundCheckForUpdate()now usesconfig.autoUpdateCheck()instead of!ConfigFile().skipUpdateCheck()Without this fix, the Sparkle update dialog reappears daily on macOS even after the user clicks "Install Update", because the delegate creates an inconsistency in Sparkle 2's state management by not properly consulting the auto-update configuration.
Fixes #9704
Test plan
skipUpdateCheckinnextcloud.cfgstill prevents all update checks