Skip to content

bpo-29922: Add more tests for error messages in 'async with'.#6370

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:async-with-more-tests
Apr 4, 2018
Merged

bpo-29922: Add more tests for error messages in 'async with'.#6370
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:async-with-more-tests

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Apr 4, 2018 •
edited by bedevere-bot
Loading

Different paths are executed for normal exit and for leaving the 'async with' block with 'break', 'continue' or 'return'.

https://bugs.python.org/issue29922

@serhiy-storchaka
bpo-29922: Add more tests for error messages in 'async with'.
0eeee8c 
Different paths are executed for normal exit and for leaving
the 'async with' block with 'break', 'continue' or 'return'.
@serhiy-storchaka serhiy-storchaka merged commit 2eeac26 into python:master Apr 4, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 4, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the async-with-more-tests branch April 4, 2018 15:45
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 4, 2018

GH-6371 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2018
@serhiy-storchaka @miss-islington
bpo-29922: Add more tests for error messages in 'async with'. (python…
4be1a39 
…GH-6370)

Different paths are executed for normal exit and for leaving
the 'async with' block with 'break', 'continue' or 'return'.
(cherry picked from commit 2eeac26)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Apr 4, 2018
@miss-islington @serhiy-storchaka
bpo-29922: Add more tests for error messages in 'async with'. (GH-6370)
785f36c 
Different paths are executed for normal exit and for leaving
the 'async with' block with 'break', 'continue' or 'return'.
(cherry picked from commit 2eeac26)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 4, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2018
@serhiy-storchaka @miss-islington
bpo-29922: Add more tests for error messages in 'async with'. (python…
598d71a 
…GH-6370)

Different paths are executed for normal exit and for leaving
the 'async with' block with 'break', 'continue' or 'return'.
(cherry picked from commit 2eeac26)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 4, 2018

GH-6373 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Apr 4, 2018
@miss-islington @serhiy-storchaka
bpo-29922: Add more tests for error messages in 'async with'. (GH-6370)
1487cd1 
Different paths are executed for normal exit and for leaving
the 'async with' block with 'break', 'continue' or 'return'.
(cherry picked from commit 2eeac26)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni