Skip to content

Fix Dynamo ordered contains semantics#184765

Open
anijain2305 wants to merge 1 commit into
gh/anijain2305/1275/basefrom
gh/anijain2305/1275/head
Open

Fix Dynamo ordered contains semantics#184765
anijain2305 wants to merge 1 commit into
gh/anijain2305/1275/basefrom
gh/anijain2305/1275/head

Conversation

@anijain2305
Copy link
Copy Markdown
Contributor

@anijain2305 anijain2305 commented May 21, 2026

Stack from ghstack (oldest at bottom):

Teach Dynamo to expose descriptor-backed method name metadata for GetAttrVariable so unittest assertRaises can reason about bound list methods.

Update iter_contains to preserve CPython's ordered rich-comparison behavior instead of skipping earlier non-constant comparisons, and remove the verified list/tuple/deque/userlist contains sentinels that now pass.

Authored by Codex.

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/184765

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 6 Pending, 108 Unrelated Failures, 20 Unclassified Failures

As of commit 859ba39 with merge base 51e8682 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests module: dynamo labels May 21, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 21, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant